I am really happy when people are quite strict in code reviews, it makes me feel safer and I get to learn more.
Nothing worse than some silent approvals with no real feedback. What if I missed something obvious… and now it’s merged.
To be fair, I also enjoy getting my grammar corrected. I’m juggling 3 languages and things can get messy.
In that spirit, I will call attention to your first sentence, specifically the comma. In my opinion, that can be improved. One of three other constructions would be more appropriate:
- I am really happy when people are quite strict in code reviews. It makes me feel safer and I get to learn more.
- I am really happy when people are quite strict in code reviews, because it makes me feel safer and I get to learn more.
- I am really happy when people are quite strict in code reviews; it makes me feel safer and I get to learn more.
The first of my suggested changes is favoured by those who follow the school of thought that argues that written sentences should be kept short and uncomplicated to make processing easier for those less fluent. To me, it sounds choppy or that you’ve omitted someone asking “Why?” after the first sentence.
Personally, I prefer the middle one, because it is the full expression of a complete state of mind. You have a feeling and a reason for that feeling. There is a sense in which they are inseparable, so not splitting them up seems like a good idea. The “because” explicitly links the feeling and reason.
The semicolon construction was favoured by my grade school teachers in the 1960s, but, as with the first suggestion, it just feels choppy. I tend to overuse semicolons, so I try to go back and either replace them with periods or restructure the sentences to eliminate them. In this particular case, I think the semicolon is preferable to both comma and period, but still inferior to the “because” construction.
I’ve clearly spent too much time hashing stuff out in writers’ groups. :)
This is what I live for. :D
I agree with most of that. In formal settings, I prefer full sentences with conjunctions; however, choppy sentences are the ones that often end up in my Lemmy comments.
That only makes sense. We are having a conversation, not creating literature.
Notably, a good code review should also bring up the good parts of the submission, and not just concentrate on the errors. Not only does it make the recipient feel better to get positive feedback among the negative, but it helps them learn about good practices too. Just concentrating on the errors doesn’t really tell them which things they’re doing well.
Many reviewers concentrate on just finding mistakes, and while it’s useful it’s sort of the bare minimum; a good code review should be educational. Especially if the submitter’s a more junior coder, in which case it’d also be a good idea to not just outright tell them how you’d fix some problem, but sort of lead them to a solution by asking them questions and pointing things out and letting them do the thinking themselves. But still, experienced coders will also benefit from well-structured feedback, it’s not like we’re “finished” and stopped learning.
Like the other guy, I also read your comment twice looking for mistakes but found none.
You should of left something to fix!
😏Edit: I’m glad there so many people who are as passionate about the correct spelling of “should’ve” as I am. I was testing you all, and you passed!
Correcting my code is helpful. The machine didn’t know what I even meant. Computers are interesting and changing rapidly.
Correcting my grammar is an unsolicited English lesson from someone who already knew what I meant. English is not interesting or changing quickly.
English changes very quickly. New words come out every year. Some programming languages takes years for updates.
Also that person may have known what you meant, but another might not and may have any number of reasons for not asking.
Better communication skills are a worthwhile goal and there’s no good reason to not learn and grow.
I mean, there’s a difference between something being phrased in an odd or confusing way, and a pedantic comment about whether you should use a Latin plural. 90% of the time you get the latter.
90+% of the time you get common mistakes. Should ofs, they’re - there - their confusions, apostrophes for plurals.
The kind of thing that confuses ESL speakers. The decent thing would seem to be to try and stick to the way it’s taught rather than go with the “it doesn’t matter” route when it absolutely matters to some.
If you’re speaking to someone ESL,
don’tdo not even use contractions. They are perfectly valid but they are confusing to those new to the language. I also like to put all idioms in quotes when writing, as those are confusing in any new language. Misspellings are less of an issue than you might think because English spellings are dumb and arbitrary already.When someone tells me “um, it is cacti, AKCTUALLY” I do not think concern for an ESL person listening in is the main motivation, though.
Cactopodes
Fuck me, never touch my code, it is perfect.
Brother you don’t even remember what it does, how and why after 3 days
Of course, but because it is perfect, no one, not even myself, needs to fix/modify/extend/understand
/s
