• AggressivelyPassive@feddit.de
    link
    fedilink
    arrow-up
    5
    ·
    8 months ago

    I have to say, I’m getting more and more frustrated by the bad code I have to write due to bad business circumstances.

    I want clean, readable code with proper documentation and at least a bit of internal consistency and not the shoehorned mess of hacks, todos and weird corner cases.

      • frezik@midwest.social
        link
        fedilink
        arrow-up
        1
        ·
        edit-2
        8 months ago

        Don’t just put “TODO”. If they’re in the final pull request, they need to mention a ticket that’s intended to fix that TODO. If you/your team decides it’s not important, then remove it and close out the ticket. Either way, you’re required to do something with it.

  • anton@lemmy.blahaj.zone
    link
    fedilink
    arrow-up
    2
    ·
    8 months ago

    Instead of

    if let Some(a_) = a{
        ()
    } else if let Some(b_)=b{
        ()
    } else {
        dostuff 
    }
    

    you could just use

    if a.isNone()&&b.isNone(){
        dostuff
    }
    

    Also if you don’t use the value in a match just use _

      • Thelie@sh.itjust.worksOP
        link
        fedilink
        arrow-up
        1
        ·
        8 months ago

        I’m not sure how I would go about this in an elegant way since I’m matching the string I get from a message…

        • jimitsoni18@lemmy.zip
          link
          fedilink
          arrow-up
          1
          ·
          8 months ago

          If the message used enums for actions/procedures like SPAM_MEMES, then using enums would be more performant

    • Thelie@sh.itjust.worksOP
      link
      fedilink
      arrow-up
      1
      ·
      8 months ago

      That’s a good point, thanks. Maybe I’ll go without the if entirely, the (janky) code is still very much in flux ;)

  • 6mementomori@lemmy.world
    link
    fedilink
    arrow-up
    1
    ·
    7 months ago

    I don’t nearly know enough to understand this but is anyone willing to help me get the thing on the top :>